[FFmpeg-devel] [PATCH] make img_convert symbol conditional on lavc version, not libswscale

[Michael Niedermayer]

On Thu, Jun 26, 2008 at 10:09:20AM +0200, Reinhard Tartler wrote:
> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
> 
> >> I can understand that distros do not like to maintain the patch, but I
> >> do neither want to maintain it!
> >> So what was it that you wanted?
> >> You want one of us to maintain your patch which is too much work for you to
> >> do?
> >
> > IMHO removing 2 lines is not much work, Im also lazy about this and I
> > just removed:
> >
> > -#ifndef CONFIG_SWSCALE
> > +//#ifndef CONFIG_SWSCALE
> >
> > -#endif
> > +//#endif
> >
> > And I have access to the old API.
> 
> Right. It is not that much work AFAIUI, and having it upstream would
> give us more eyes to watch out for problems caused by this.

The question is, do we have someone who is willing and able to maintain
it? One who will fix bugs reported by users in case there are any ...
So far people just said they want the patch, also at least one said
that he wouldnt be able to maintain it. I do not remember anyone
volunteering to maintain this patch ...


> Distros are
> carrying this patch for years now without serious concerns, after all,
> so it cannot be that broken as one might suspect in the first place.

Distros are carrying alot for years ...

My general rule of thumb is nowadays, if something doesnt work and its not
obviously my own fault, it tends to be the vendors fault more often than
upstreams ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080630/b3209b07/attachment.pgp>