[FFmpeg-devel] [PATCH] Libavfilter build fix

[Aurelien Jacobs]

V?ctor Paesa wrote:

> Hi,
> 
> Vitor Sessak said:
> > Hi
> >
> > V?ctor Paesa wrote:
> >> Vitor Sessak said:
> >>> Hi,
> >>>
> >>> Mans and vmrsss spotted some bugs in building libavfilter. The
> >>> patch I attached fix it and also make its build system more in
> >>> line with the other lav*.
> >>
> >>> +find_things2(){
> >>> +    thing=$1
> >>> +    pattern=$2
> >>> +    file=$source_path/$3
> >>> +    sed -n "s/^[^#]*$pattern.*(.*,\\(.*\\),.*).*/\\1_$thing/p"
> >>> "$file" +}
> >>
> >> I am wondering if the filters should follow the suffix tagging
> >> style as (en)coders/parsers/protocols/(de)muxers, i.e.
> >> "movie_vsrc" instead of "vsrc_movie" and so on.
> >
> > Well, now the struct is named avfilter_vsrc_movie. Do you suggest
> > just movie_vsrc or movie_vsrc_filter?
> 
> I'd say that "movie_vsrc" would be enough.
> 
> > The thing I like in the way it is are
> > the filenames ("vsrc_movie.c" is tidy when doing ls libavfilter/)...
> 
> > Irrespective of how we tag it, I don't think it is a good idea to
> > make a distinction in the configure parameters (having all the
> > --enable-{video,audio,subtitle,etc}-filter=xxx would be an
> > overkill), so we'll need a special handling in configure anyway.
> 
> Now filters are quite slim, but maybe in future people starts creating
> complex ones, hence I would prefer the
> --enable-{video,audio,subtitle,etc}-filter=xxx style, even more if
> that avoids special handling in configure.

Classifying filters in categories such as video and audio sound strange.
How would you classify a filter with one audio input pad, one subtitle
input pad and one video output pad ?

Aurel