[FFmpeg-devel] [PATCH] RTSP alternate protocol 2-3/3

Michael Niedermayer michaelni
Sun Mar 2 01:53:44 CET 2008


On Thu, Feb 14, 2008 at 09:01:00AM -0500, Ronald S. Bultje wrote:
[...]
> @@ -1075,9 +1079,18 @@
>          goto fail;
>      }
>  
> -    err = make_setup_request(s, host, port, protocol_mask);
> -    if (err)
> +    do {
> +        int protocol = protocol_mask & ~(protocol_mask - 1);
> +
> +    err = make_setup_request(s, host, port, protocol);
> +    if (err < 0)
>          goto fail;
> +        protocol_mask &= ~protocol;
> +        if (protocol_mask == 0 && err == 1) {
> +            err = AVERROR(EPROTONOSUPPORT);
> +            goto fail;
> +        }
> +    } while (err);

New lines are wrongly indeted.
Also i suspect this code will leak various things.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080302/1da4e7df/attachment.pgp>



More information about the ffmpeg-devel mailing list