[FFmpeg-devel] [PATCH] Factorize ffmpeg.c:opt_frame_pad_* functions

[Michael Niedermayer]

On Mon, Mar 03, 2008 at 09:23:29AM +0100, Stefano Sabatini wrote:
> On date Monday 2008-03-03 02:59:02 +0100, Diego Biurrun encoded:
> > On Sun, Mar 02, 2008 at 09:33:38PM +0100, Stefano Sabatini wrote:
> > > 
> > > as in $subject (patch for making it use parse_number_or_die rather
> > > than atoi incoming).
> > > 
> > > --- libavcodec/opt.c	(revision 12279)
> > > +++ libavcodec/opt.c	(working copy)
> > > @@ -298,6 +330,13 @@
> > >  
> > > +/**
> > > + * Lists all options contained in the AVClass object pointed by \p obj.
> > 
> > pointed to by
> > 
> > > + * @param[in] obj Pointer to an AVClass object.
> > 
> > This sentence has no verb, hence it is not a sentence and you should not
> > capitalize and add a period at the end.  Same in other places.
> 
> No, this time I sent the wrong patch, sorry for having wasted your
> time.
> 
> Attached there is the correct one.
> 
> Regards.
> -- 
> Stefano Sabatini
> Linux user number 337176 (see http://counter.li.org)

> Index: ffmpeg.c
> ===================================================================
> --- ffmpeg.c	(revision 12291)
> +++ ffmpeg.c	(working copy)
> @@ -2316,58 +2316,38 @@
>      padcolor[2] = RGB_TO_V(r,g,b,0);
>  }
>  
> -static void opt_frame_pad_top(const char *arg)
> +static int parse_frame_pad_size_or_die(const char *context, const char *arg)
>  {

As pad/crop/scale/... will disapear with the inclusion of avfilter, iam not
going to review this or related cleanups. If someone else wants he can.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080303/b10b1b4b/attachment.pgp>