[FFmpeg-devel] [PATCH] VFW capture support

Ramiro Polla ramiro
Mon Mar 3 18:20:23 CET 2008


Hello Diego,

Diego Biurrun wrote:
> On Mon, Mar 03, 2008 at 02:07:23PM -0300, Ramiro Polla wrote:
>> Rich Felker wrote:
>>> On Mon, Mar 03, 2008 at 03:19:55AM -0300, Ramiro Polla wrote:
>>>>> It is preferred to have no whitespace immediately inside () in FFmpeg.
>>>> This is my preferred style, and I'll maintain this file. You won't need 
>>>> to look at it after it gets into SVN.
>>> This is not the way to make people feel positive about accepting your
>>> code...
>> This makes me wonder... How much code do you have in FFmpeg, again?
> 
> None to speak of.
> 
> But I have to agree with the sentiment voiced here: The style used
> throughout FFmpeg should be consistent.  We all have to make a few
> compromises to achieve this.

Ok. After the next review round it'll be changed.

Ramiro Polla




More information about the ffmpeg-devel mailing list