[FFmpeg-devel] [PATCH] fix 'warning: initialisation from incompatible pointer type' in aes.c

[Michael Niedermayer]

On Wed, Mar 05, 2008 at 02:11:53PM +0100, Reimar D?ffinger wrote:
> On Wed, Mar 05, 2008 at 11:41:51PM +1100, mark cox wrote:
> > On Wed, Mar 5, 2008 at 11:32 PM, Michael Niedermayer <michaelni at gmx.at>
> > wrote:
> > > On Wed, Mar 05, 2008 at 08:05:46PM +0800, Zuxy Meng wrote:
> > > > 2008/3/5, Michael Niedermayer <michaelni at gmx.at>:
> > > > > On Wed, Mar 05, 2008 at 10:11:37PM +1100, mark cox wrote:
> > > > > > fix 'warning: initialisation from incompatible pointer type' in
> > > aes.c
> > > > >
> > > > > rejected, learn C, test your code like the patch submission guidlines
> > > > > require, ...
> > > >
> > > > Any problem with this patch???
> > >
> > > yes
> > > hint: the patch removes a warning, sadly the code wont work anymore
> > > afterwards.
> > >
> > 
> > I have seen my error, but i can't figure out the correct/non-messy cast to
> > do what i want.
> 
> You touch the heart of why aes.c generates so many warnings :-)

Yes, why dont we just disable these warnings for aes.c ?
diego/mans ?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080305/7a07eda5/attachment.pgp>