[FFmpeg-devel] [PATCH] move ff_emulated_edge_mc() to dsputil

Michael Niedermayer michaelni
Wed Mar 5 22:43:47 CET 2008


On Wed, Mar 05, 2008 at 08:27:19PM +0200, Uoti Urpala wrote:
[...]
> > No benchmarks were provided, even though it has been requested multiple
> > times, and uoti indicated that the main suggestion caused a slowdown.
> > So i droped all related patches in the sense that i would not
> > bother any further until someone did provide benchmarks. Noone provided
> > any so far ...
> 
> For the reasons explained in the quoted post above I have little
> motivation to do much work on optimization or benchmarking of
> motion_est. I wouldn't expect the patch I posted to cause slowdown. Just
> making the cmp function non-inline might or might not cause slowdown
> (could depend on the use case too). Even if that does I believe it's
> possible to write the code in a smarter way that removes most of the
> repeated code without slowdown (like the example patch does for a small
> chunk of code).

I agree, also like you i as well have little motivation to benchmark your
patch or implement your suggestions.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080305/f347671f/attachment.pgp>



More information about the ffmpeg-devel mailing list