[FFmpeg-devel] [PATCH] Add default stream flag

[Michael Niedermayer]

On Sun, Mar 02, 2008 at 04:20:55AM +0300, Evgeniy Stepanov wrote:
> On Friday 29 February 2008 16:58:36 Michael Niedermayer wrote:
> > On Fri, Feb 29, 2008 at 05:46:59AM +0300, Evgeniy Stepanov wrote:
> > > On Friday 29 February 2008 04:51:04 Michael Niedermayer wrote:
> > > [...]
> > >
> > > > > +static void set_disposition_bits(AVFormatContext* avf, char* value,
> > > > > unsigned int stream_id_plus1){ +    int flag = 0, i;
> > > > > +    for (i=0; ff_nut_dispositions[i].flag != 0; ++i) {
> > > >
> > > > the != 0 is superflous
> > > >
> > > > > +        if (!strncmp(ff_nut_dispositions[i].str, value,
> > > > > +                     strlen(ff_nut_dispositions[i].str))) {
> > > >
> > > > why strncmp() and not strcmp() ?
> > >
> > > Mindless copypaste from matroska* )
> >
> > looks ok (maybe with a minor version bump for the disposition addition to
> > AVStream)
> >
> > [...]
> 
> Could it be committed then ? Attached is the same patch with lavf minor 
> version increased.

Dont you have a svn write account? Or is that limited to mplayer?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I count him braver who overcomes his desires than him who conquers his
enemies for the hardest victory is over self. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080307/14440e41/attachment.pgp>