[FFmpeg-devel] [PATCH] remove MSVC-specific

[Michael Niedermayer]

On Sun, Mar 09, 2008 at 10:27:32AM +0100, Reimar D?ffinger wrote:
> On Sun, Mar 09, 2008 at 01:04:33AM -0600, Brian Brice wrote:
> > On Sat, Mar 8, 2008 at 3:40 PM, M?ns Rullg?rd <mans at mansr.com> wrote:
> > > Michael Niedermayer <michaelni at gmx.at> writes:
[...] 
> > >  The situation hasn't improved.
> > 
> > These flames are becoming pretty ridiculous and very childish.  As
> > someone that has successfully compiled ffmpeg with MSVC, and also uses
> > mingw compiled libraries with MSVC projects, the stuff you are always
> > trying to remove only become very bothersome for someone like me.
> 
> Well, since you did that you can surely answer if that stuff is even
> necessary. Since MSVC can not compile the inline asm I don't know what
> it would be good for...

One could compile i386/ with gcc or icc and the rest with msvc. Also thouse
maintaining a hacked ffmpeg which compiles in MSVC have IIRC some sort of
asm i dont rememer if it was gcc compiled or ported but i dont think that
there was just pure C code.


> 
> > And
> > I know I'm not alone!  I appreciate things like this available in the
> > code already.  I certainly don't appreciate the removal of these
> > things because of your own personal grudges and ignorances.
> 
> Well, do you step up and maintain all the MSVC related lines, making
> sure they still serve a sense and are correct? If no-one volunteers to
> do that I too see no point in keeping them. Better something not there
> than something that pretends to work but does not.

If you propose to remove all code that could be wrong compared to code that
is known to be wrong then you will have to remove alot. Especially in some
reverse engeneered codecs. Theres no lack of unmaintained code that is rarly
used and is maybe wrong.
If the code in question really is wrong someone will notice this and report
it, we can then either fix it or remove the code. Removing code just because
it could be wrong is a philosophy by which no complex program can be written.
How much code is there in mplayer which could be wrong? Or where you are not
sure its correct?

Also i assume that whoever wrote the 2 lines had tested them so i would guess
they are more likely correct than not.

And yes, i also would appreciate if we had some maintainer for MSVC related
hunks.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080309/c0a9d754/attachment.pgp>