[FFmpeg-devel] [PATCH] remove MSVC-specific

[Måns Rullgård]

pross at xvid.org writes:

> On Tue, Mar 11, 2008 at 02:59:51PM +0100, Reimar D?ffinger wrote:
>> I do not know who you think of, but if you haven't noticed gcc,
>> binutils, Solaris userland, OS/2 all have received similar levels of
>> flames (and in the case of OS/2 IIRC much harder to reimplement code was
>> removed than this MSVC stuff). Also IIRC for OS/2 things moved much more
>> smoothly after people stopped insisting on ugly hacks.
>
> this line of argument would be justified if the patch that iniaited this
> discussion was to remove an 'ugly hack'. but the two lines of code
> in mem.h are not ugly, and if anything, replicate similiar 'ugly
> hacks' used for memory alignment with icc and gcc.

The difference is that the gcc lines are actually *used*.  There is so
far no evidence whatsoever that the msvc lines are used, let alone
correct.

-- 
M?ns Rullg?rd
mans at mansr.com