[FFmpeg-devel] [PATCH] add #include "config.h" to internal libavutil headers

[Diego Biurrun]

On Thu, Mar 13, 2008 at 08:14:55PM +0000, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> 
> > On Thu, Mar 13, 2008 at 09:08:54AM +0000, M?ns Rullg?rd wrote:
> >> Diego Biurrun <diego at biurrun.de> writes:
> >> 
> >> > This adds a few #include "config.h" to internal libavutil headers to
> >> > make them self-contained.
> >> >
> >> > --- libavutil/intreadwrite.h	(revision 12430)
> >> > +++ libavutil/intreadwrite.h	(working copy)
> >> > @@ -21,6 +21,7 @@
> >> >  
> >> >  #include <stdint.h>
> >> >  #include "bswap.h"
> >> > +#include "config.h"
> >> 
> >> If included at all, config.h should be before any other FFmpeg
> >> headers.
> >
> > Well, why not before all headers, including system ones, then?
> 
> The system headers don't care what CONFIG_* we've set.

They can care for ARCH_ or _ISOC9X_SOURCE or restrict or other
settings, might they not...?

Diego