[FFmpeg-devel] [PATCH] mpeg2 non linear quantizer full support

[Baptiste Coudurier]

Hi,

Aurelien Jacobs wrote:
> Baptiste Coudurier wrote:
> 
>> Hi,
>>
>> $subject.
>>
>> Diff for some files is to show possible simplifications of existing
>> code. I'll of course split the commits. Only mpeg-2 unquantize
>> functions are affected.
>>
>> [...]
>>
>> Index: libavcodec/mpegvideo.c
>> ===================================================================
>> --- libavcodec/mpegvideo.c	(revision 12407)
>> +++ libavcodec/mpegvideo.c	(working copy)
>> @@ -33,6 +33,7 @@
>>  #include "mpegvideo_common.h"
>>  #include "mjpegenc.h"
>>  #include "msmpeg4.h"
>> +#include "mpeg12.h"
>>  #include "faandct.h"
>>  #include <limits.h>
> 
> I'm curious to know why you include mpeg12.h (here at at some other
> places in this patch) ? I can't see anything which would require it.

Yes, I figured that out.

> Moreover, in case you add a dependency to mpeg12.o, you also need to
> adjust the Makefile (but I guess this would add lots of ugly, almost
> useless dependencies).
> Maybe you could find a better place to put the new *_qscale table to
> reduce artificial dependencies.

Ok, I'll find a nice place.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG SAS                                     http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312