[FFmpeg-devel] [PATCH] Enable building 64bit FFmpeg on MacOSX
İsmail Dönmez
ismail
Mon Mar 17 20:16:44 CET 2008
Hi,
On Mon, Mar 17, 2008 at 2:22 PM, Reimar D?ffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> On Mon, Mar 17, 2008 at 01:55:14PM +0200, ?smail D?nmez wrote:
> > On Mon, Mar 17, 2008 at 1:10 PM, Reimar D?ffinger
>
> > > Seems ugly to me, maybe better check compilation of something like
> > >
> > > int test[sizeof(intptr_t) - 7];
> >
> > I don't particularly think checking sizeof(long) is ugly but I don't
> > mind using intrptr_t if M?ns agrees. Such a patch is attached.
>
> What seemed ugly to me was the test involving execution.
> sizeof(long) is somewhat ugly because it probably checks the wrong
> thing, though my suggestion is not much better, it should probably be
> sizeof(void *), though even that is not optimal because it does not
> _really_ indicate if 64 bit operations are fast or not...
The code we modify is enabled with --arch=x86_64 so we already assume
64bit operations are fast.
Regards,
ismail
--
Never learn by your mistakes, if you do you may never dare to try again.
More information about the ffmpeg-devel
mailing list