[FFmpeg-devel] [PATCH] replace hardcoded offset of CABACContext.bytestream with "m" operand

[Måns Rullgård]

Uoti Urpala <uoti.urpala at pp1.inet.fi> writes:

> On Mon, 2008-03-17 at 21:01 +0000, Mans Rullgard wrote:
>> -        :"r"(state), "r"(c)
>> +        :"r"(state), "r"(c), "m"(c->bytestream)
>
> Why replace one of the hardcoded offsets while leaving all the others?

Because I'm lazy and they don't depend on #ifdefs.

> Replacing them all (or using "+m"(*c) as I did earlier) also has the
> performance benefit that for inlined versions gcc can calculate the
> offsets based directly on H264Context. Leaving the "r"(c) requires it to
> place &h->cabac in a register.

I don't recall seeing that patch (which isn't saying much).  Was it
rejected?  Ignored?

-- 
M?ns Rullg?rd
mans at mansr.com