[FFmpeg-devel] [PATCH] fix compilation (was Re: r12489 broke all builds)

[Michael Niedermayer]

On Wed, Mar 19, 2008 at 11:08:56AM +0800, Zuxy Meng wrote:
> Hi,
> 
> 2008/3/19, Benoit Fouet <benoit.fouet at purplelabs.com>:
> > Michael Niedermayer wrote:
> > > On Tue, Mar 18, 2008 at 12:22:41PM -0400, Alexander Strange wrote:
> > >
> > >> On Mar 18, 2008, at 12:13 PM, Mike Melanson wrote:
> > >>
> > >>> Check FATE:
> > >>>
> > >>>  http://fate.multimedia.cx/
> > >>>
> > >>> --
> > >>>     -Mike Melanson
> > >>>
> > >> Missing include in rational.h.
> > >>
> > >
> > > ok
> > >
> > >
> >
> > as already mentionned, I'll let Zuxy apply this one along with his patch.
> > again, sorry for this bad commit :(
> 
> I should have run a distclean before building and sending the patch.
> Anyway now we have 3 ways to fix the build:
> 
> 1. Include "common.h" in "rational.h"
> 2. Include "common.h" in "mpeg12data.h"
> 3. Include "common.h" in "mpeg12data.c"
> 
> The only .c file that failed to compile is mpeg12data.c. All other
> files that use "rational.h" have included "common.h" either directly
> or indirectly.
> 
> Maybe Diego can point to me the cleanest approach?

The cleanest approuch is to never include headers from other headers.
But i suspect that i, ivan and arpi are in the minority with that view.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080319/6ee844e6/attachment.pgp>