[FFmpeg-devel] [PATCH] exporting mpeg user_data

[Reimar Döffinger]

On Wed, Mar 19, 2008 at 08:33:22AM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> > On Wed, Mar 19, 2008 at 02:12:42AM +0000, M?ns Rullg?rd wrote:
> > [...]
> >> >> > Michael says: see FF_OPT_TYPE_BINARY
> >> >> > M?ns Rullg?rd says: This makes no sense at all.
> >> >> 
> >> >> Honestly, I have to plead ignorance on this one. I don't fully know
> >> >> what the hell I'm doing, I'm not intimately familiar with the
> >> >> design of ffmpeg. So, being a complete noob, I simply copied what
> >> >> was done for the extradata field.
> >> >
> >> > look at AVFormatContext.key/keylen and the cryptokey entry as references
> >> > also dont hesitate to read the code in opt.c related to FF_OPT_TYPE_BINARY
> >> 
> >> This is a decoder output field.  Setting it doesn't make sense.  Even
> >> if the encoder supported user_data injection, this would be the wrong
> >> place to set it.
> >
> > It of course should be in AVCodecContext but key/keylen is a example of a
> > FF_OPT_TYPE_BINARY ...
> 
> It's not the field being in AVCodecContext I'm saying is wrong, but
> the entry for it in the AVOption array.  There is no sense in setting
> it from the command line, especially when it is an output-only field.

Not sure if it applies here, but the AVOption stuff can also be used to
print things...