[FFmpeg-devel] [PATCH] code to parse mpeg4audio extradata

[Andreas Öman]

Hi,

Baptiste Coudurier wrote:
> ...
> 
> if (specific_config && specific_config(gb, v) < 0)
>     return -1;
> 
> What do you think ?

Looks fine to me.

>> But without specific parser for all used audioObjectTypes i don't see
>> how the code below here is supposed to work at all (since it will
>> read the wrong bits)
> 
> Yes, probably, if we want to support all configurations and modes, it
> will to be extended for sure, also maybe code could search syncword.

Yeah, I would guess the syncword is there for that particular reason.