[FFmpeg-devel] Update: IFF 8SVX Demuxer Patch rev2

[Jai Menon]

On Sunday 23 March 2008 12:08:04 Diego Biurrun wrote:
> On Sun, Mar 23, 2008 at 12:30:07PM +0000, Jai Menon wrote:
> > I'll wait for your comments.
> >
> > --- libavformat/iff.c	(revision 0)
> > +++ libavformat/iff.c	(revision 0)
> > @@ -0,0 +1,219 @@
> > +/*
> > + * IFF (.iff) File Demuxer
>
> Here and in lots of other places: Please do not capitalize all words.
>
> > + * Copyright (c) 2008 The ffmpeg Project
>
> The FFmpeg project is not a legal entity.
>
> > +    while(!done)
> > +    {
> > +      chunk_id = get_le32(pb);
>
> Use 4 spaces indentation.
>
> Also, you have tabs and trailing whitespace in your patch.
>
> Diego
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at mplayerhq.hu
> https://lists.mplayerhq.hu/mailman/listinfo/ffmpeg-devel


Thanks for the comments.
Revision 3: Fixed
Please find patch attached.

Regards,

Jai Menon
<realityman at gmx.net> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: IFF-8SVX_demuxer_rev3.patch
Type: text/x-diff
Size: 7952 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080323/b25ec329/attachment.patch>