[FFmpeg-devel] [PATCH] IFF demuxer and 8SVX decoder

[Jai Menon]

On Wednesday 26 March 2008 16:35:10 Michael Niedermayer wrote:
> On Wed, Mar 26, 2008 at 08:05:54PM +0000, Jai Menon wrote:
> > +        esc->fib_acc += esc->table[d & 0x0f];
> > +        av_clip_uint8(esc->fib_acc);
> > +        *out_data++ = esc->fib_acc << 8;
> > +        esc->fib_acc += esc->table[d >> 4];
> > +        av_clip_uint8(esc->fib_acc);
> > +        *out_data++ = esc->fib_acc << 8;
>
> you are not checking if the out_data buffer is large enough
How exactly do i do that? i looked through a majority of decoders and none of 
them seem to perform such a check.....but i may be missing something

> >
> > +    uint32_t channels;
>
> could be a local var

I need this in the context because i use it to compute the audio frame count 
in the read packet method


Patch with other changes applied is attached.

Regards
Jai Menon
<realityman at gmx.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8svx_decoder.patch
Type: text/x-diff
Size: 5188 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080327/3efe4a6f/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff_demuxer.patch
Type: text/x-diff
Size: 6969 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080327/3efe4a6f/attachment-0001.patch>