[FFmpeg-devel] [PATCH] h264/aac in flv

[Baptiste Coudurier]

Hi Michael,

Michael Niedermayer wrote:
> [...]
>> @@ -369,6 +385,19 @@
>>          size -= flv_set_video_codec(s, st, flags & FLV_VIDEO_CODECID_MASK);
>>      }
>>  
>> +    if (st->codec->codec_id == CODEC_ID_AAC ||
>> +        st->codec->codec_id == CODEC_ID_H264) {
>> +        int type = get_byte(s->pb);
>> +        size--;
>> +        if (st->codec->codec_id == CODEC_ID_H264)
>> +            pkt->pts = dts + get_be24(s->pb);
>> +        if (type == 0) {
>> +            if ((ret = flv_get_extradata(s, st, size - 1)) < 0)
>> +                return ret;
>> +            goto retry;
>> +        }
>> +    }
> 
> Are multiple type 0 packets allowed? extradata must be strictly global and
> must never change. Maybe these could be passed like normal packets? In which
> case that problem would disapear.

Quoting specs:
"See ISO 14496-15, 5.2.4.1 for the description of
AVCDecoderConfigurationRecord. This contains the same information that
would be stored in an avcC box in an MP4/FLV file."
"The AudioSpecificConfig is explained in ISO 14496-3."

So I guess this should not appear, if it does, I will update the code,
because passing it as normal packet will require decoder modifications I
think. What do you think ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA