[FFmpeg-devel] [PATCH] define private libs properly in pkgconfig files

[Diego Biurrun]

On Tue, May 06, 2008 at 08:27:58AM +0300, Anssi Hannula wrote:
> Diego Biurrun wrote:
> > On Tue, May 06, 2008 at 12:08:51AM +0300, Anssi Hannula wrote:
> >> Currently all the libraries ffmpeg links against are listed in "Libs:"
> >> of *.pc files.
> >>
> >> However, those libraries need to be specified only when a program is
> >> linked statically against ffmpeg, not when ffmpeg is a shared library.
> >> Therefore one should use "Libs.private:" instead of "Libs:".
> >> Quote from pkg-config man page:
> >>>        Libs.private:
> >>>               This  line  should  list any private libraries in use.  Private libraries are libraries which are not exposed
> >>>               through your library, but are needed in the case of static linking.
> >> Patch attached.
> > 
> > This was too confusing.  I have rewritten the two pkg-config generation
> > commands into one simpler one.  Please update your patch, it should be
> > far less intrusive now.
> 
> Updated, tested and attached.

This one was far easier to review, so my rewrite was successful.  Patch
applied, thanks a bundle.

Diego