[FFmpeg-devel] [PATCH] MMX for Win64

Ramiro Polla ramiro
Wed May 7 00:55:19 CEST 2008


> *_t is reserved by POSIX.

Well, then I guess you should take care of the rest of the code that 
typedefs _t stuff:
ramiro at found:/usrc/ffmpeg/src$ grep -r typedef * | grep "_t;"
libavcodec/vp56.h:typedef struct vp56_context vp56_context_t;
libavcodec/vp56.h:typedef struct vp56_mv vp56_mv_t;
libavcodec/i386/dsputil_mmx.h:typedef struct { uint64_t a, b; } xmm_t;
libavformat/iff.c:typedef enum {COMP_NONE, COMP_FIB, COMP_EXP} 
svx8_compression_t;
libavformat/avio.h:typedef int64_t offset_t;
libavformat/os_support.h:typedef int socklen_t;
libavformat/os_support.h:typedef unsigned long nfds_t;
libpostproc/postprocess.h:typedef void pp_context_t;
libpostproc/postprocess.h:typedef void pp_mode_t;
tests/videogen.c:typedef unsigned char uint8_t;

And what about being constructive from time to time? Like "*_t is 
reserved by POSIX. Why don't you use <...> instead?". Oh, and also 
mentioning where POSIX says that would be even better. That would be 
good for your karma =)

Ramiro Polla




More information about the ffmpeg-devel mailing list