[FFmpeg-devel] [PATCH] MMX for Win64

[Baptiste Coudurier]

M?ns Rullg?rd wrote:
> Baptiste Coudurier wrote:
>> Hi Mans,
>>
>> M?ns Rullg?rd wrote:
>>> Diego Biurrun <diego at biurrun.de> writes:
>>>
>>>> On Wed, May 07, 2008 at 02:03:50AM +0100, Ramiro Polla wrote:
>>>>>   wrote:
>>>>>> Aurelien Jacobs <aurel at gnuage.org> writes:
>>>>>>
>>>>>>> M?ns Rullg?rd wrote:
>>>>>>>
>>>>>>>> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
>>>>>>>>
>>>>>>>>>> *_t is reserved by POSIX.
>>>>>> [...]
>>>>>>
>>>>>> Regardless of the precise semantics intended, I think it's a bad idea
>>>>>> to invade this namespace.
>>>>> You forgot the "being constructive" part.
>>>> OK guys, how hard can it be?  Just replace _t with _type or with
>>>> _struct.
>>>>
>>>>   ramiro at found:/usrc/ffmpeg/src$ grep -r typedef * | grep "_t;"
>>>>   libavcodec/vp56.h:typedef struct vp56_context vp56_context_t;
>>>>   libavcodec/vp56.h:typedef struct vp56_mv vp56_mv_t;
>>>>
>>>> Maybe just write 'struct vp56_mv' everywhere..
>>> There are good reasons not to use typedefs for structs (or pointers).
>>> I avoid doing it in new code.
>> Oh, can you please elaborate a little ? Im really interested in knowing why.
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/CodingStyle;hb=HEAD#l270
> 
> Extrapolate from there.
> 

Thanks, interesting reading. However Im not convinced.

Let's troll a bit ;)

If I understood correctly: the "for structures and pointers" not meaning
both in the same typedef.

I think putting "struct" litter all around the code is just waste of
space/bytes.

Im ok to forbid typedefing pointers but clearly not structs.
"a->" or "a." is explicit enough, and looking at the declaration, type
will be known.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc.                                http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA