[FFmpeg-devel] [PATCH] Some ra144.c simplifications

Alexander Strange astrange
Sun May 11 20:50:29 CEST 2008


On 5/11/08, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Sun, May 11, 2008 at 05:45:29PM +0200, Vitor Sessak wrote:
>> Michael Niedermayer wrote:
>>> On Sat, May 10, 2008 at 04:50:03PM +0200, Vitor Sessak wrote:
>>>> Hi,
>>>>
>>>> libavcodec/ra144.c really needs some cleanup. I'll start with the
>>>> following:
>>>>
>>>> ra144_indent.diff: Reindent the whole file. Since there was no
>>>> substantial change in this file since it inclusion in 2003, I don't
>>>> think there is any problem in making its indentation inline with the
>>>> rest of FFmpeg.
>>>>
>>>> ra144_unpack_rewrite.diff: Rewrite completely unpack_input()
>>>>
>>>> ra144_simp{1,2}.diff: minor simplifications
>>> all ok if you have tested your code
>>
>> Next round:
>>
>> ra144_simp{3,4}.diff: minor simplifications (FFSWAP, unused stuff removal)
>
> ok

>>
>> ra144_do_voice.diff: simplify do_voice()
>>
>
>> ra144_split_val.diff: glob->val is unrelated with the rest of the
>> unpacked buffer. This patch split its table out of the others
>
> ok

Applied simp{3,4} and do_voice.




More information about the ffmpeg-devel mailing list