[FFmpeg-devel] [Patch] Fix icc warning #120 for pcx.c

[Carl Eugen Hoyos]

Hi!

Reimar D?ffinger <Reimar.Doeffinger <at> stud.uni-karlsruhe.de> writes:

> > libavcodec/pcx.c(61): warning #120: return value type does not match the 
> > function type
> >       return src;
> >              ^
> >
> > OK or should I just silence the warning (this is the only occurence)?
> 
> Since it basically returns the first input pointer, it should have the
> same type. So it should be uint8_t *.

So the following patch is ok?

Thank you, Carl Eugen

Index: libavcodec/pcx.c
===================================================================
--- libavcodec/pcx.c    (revision 13132)
+++ libavcodec/pcx.c    (working copy)
@@ -42,7 +42,7 @@
 /**
  * @return advanced src pointer
  */
-static const char *pcx_rle_decode(const uint8_t *src, uint8_t *dst,
+static const uint8_t *pcx_rle_decode(const uint8_t *src, uint8_t *dst,
                             unsigned int bytes_per_scanline) {
     unsigned int i = 0;
     unsigned char run, value;