[FFmpeg-devel] [PATCH] Use pkg-config for libschroedinger libs

[Ramiro Polla]

  wrote:
> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
> 
>> Reimar D?ffinger wrote:
>>> On Mon, May 12, 2008 at 05:13:04PM +0100, Ramiro Polla wrote:
>>>>>>>> also pkg-config is used in the line above for cflags,
>>>>>>>> the patch just fixes one missing use of pkg-config
>>>>>>> Two wrongs don't make a right.
>>>>>> just pointing it out, leaving it like it is now sure is the worst
>>>>>> solution.
>>>>>>
>>>>>> a) use pkg-config and use it in all cases
>>>>>> b) dont use pkg-config at all
>>>>>>
>>>>>> the patch fixes configure to conform to a)
>>>>>> you propose b) instead?
>>>>>>
>>>>>> what are those systems without pkg-config if i may ask?
>>>>> That's irrelevant.  As long as pkg-config isn't mandated by
>>>>> POSIX, we should assume it might not be there.
>>>> We should get rid of memalign() too. After all, it's not POSIX...
>>> Huh? FFmpeg already works without memalign. And there is even a hack
>>> that allows even the assembler optimizations to work without it.
>> Well, then it should be a configure option:
>> ./configure --enable-memalign
>>
>>> So to me it seems your example actually confirms Mans' opinion?
>>> Also I think there is no problem to _also_ try pkg-config, but depending
>>> on it really is not a great thing - also as it encourages projects using
>>> pkg-config to do sloppy dependency-managment.
>> Good idea. It doesn't take an extraordinary amount of time and effort
>> to come up with an idea like attached patch.
>>
>> [...]
>>
>> Ramiro Polla
>> Index: configure
>> ===================================================================
>> --- configure	(revision 13138)
>> +++ configure	(working copy)
>> @@ -572,14 +572,19 @@
>>  EOF
>>  }
>>
>> -require(){
>> +require_try(){
>>      name="$1"
>>      header="$2"
>>      func="$3"
>>      shift 3
>> -    check_lib $header $func "$@" || die "ERROR: $name not found"
>> +    check_lib $header $func "$@"
>>  }
> 
> Yes, reinventing wheels is easy.  That looks a hell of a lot like
> check_lib to me.

Even better... New suggestion in form of patch.

Ramiro Polla
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schroedinger.diff
Type: text/x-patch
Size: 1050 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080512/ae1cf2a6/attachment.bin>