[FFmpeg-devel] [PATCH] Add ADPCM codec long_names
Aurelien Jacobs
aurel
Wed May 14 01:46:40 CEST 2008
Stefano Sabatini wrote:
> Hi, as in subject,
>
> please especially maintainers comment on the choice of the long_name
> for your maintained codecs.
>
> [...]
>
> Index: libavcodec/adpcm.c
> ===================================================================
> --- libavcodec/adpcm.c (revision 13150)
> +++ libavcodec/adpcm.c (working copy)
> @@ -1594,7 +1594,7 @@
>
>
> #ifdef CONFIG_ENCODERS
> -#define ADPCM_ENCODER(id,name) \
> +#define ADPCM_ENCODER(id,name,_long_name) \
Identifiers starting with an _ are reserved by the C language.
So please avoid them.
> +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_2, adpcm_sbpro_2, "Sound Blaster Pro 2 ADPCM");
Sound Blaster Pro 2 bits ADPCM
> +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_3, adpcm_sbpro_3, "Sound Blaster Pro 3 ADPCM");
Sound Blaster Pro 2.6 bits ADPCM
> +ADPCM_DECODER(CODEC_ID_ADPCM_SBPRO_4, adpcm_sbpro_4, "Sound Blaster Pro 4 ADPCM");
Sound Blaster Pro 4 bits ADPCM
Aurel
More information about the ffmpeg-devel
mailing list