[FFmpeg-devel] aac_ac3_parser.c bug with splitted headers+ patch

[Michael Niedermayer]

On Mon, May 12, 2008 at 12:28:01PM +0200, Nir Drang wrote:
> Here is the attached patch
> 
> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu
> [mailto:ffmpeg-devel-bounces at mplayerhq.hu] On Behalf Of Stefano Sabatini
> Sent: Sunday, May 11, 2008 7:18 PM
> To: ffmpeg-devel at mplayerhq.hu
> Subject: Re: [FFmpeg-devel] aac_ac3_parser.c bug with splitted headers+
> patch
> 
> On date Sunday 2008-05-11 20:00:02 +0200, Nir Drang encoded:
> > Hi ,
> > 
> > This is my first post so If I have violated any rules regarding posting
> > messages please let me know.
> > 
> > I have created a ts file with aac audio and h.264 using a trranscoding
> phase
> > from mpeg2+ac3 using ffmpeg .
> > 
> >  
> > 
> > Now when I try to convert the output to mp4 I noticed that the audio frame
> > rate is wrong and other strange stuff happening.
> > 
> > I debugged it and discovered that when the aac header (7 bytes) was
> residing
> > cross ts packets there is a bug.
> > 
> > In my scenario 6 header bytes were in one ts packet and 1 header byte was
> in
> > the second packet.
> > 
> >  
> > 
> > It looked like the code doesn't handle this situation quite well.
> > 
> > I have patched it and requesting your comments to my patch , I might have
> > broke something else :

Yes, EAC-3 should be broken after the patch, also i do not think it fixes
any bug.

Could you upload the problematic ac3 in ts file so we could take a look?
(a small part which contains the problematic split frame should be enough)
also could you check if
    hdr_info->samples = (rdb + 1) * 1024;
    hdr_info->bit_rate = size * 8 * hdr_info->sample_rate / hdr_info->samples;

    *need_next_header = 0;
-   *new_frame_start  = 1;
+   *new_frame_start  = 0;
    return size;


fixed the problem?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I am the wisest man alive, for I know one thing, and that is that I know
nothing. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080514/16315f92/attachment.pgp>