[FFmpeg-devel] [PATCH] Some ra144.c simplifications

[Michael Niedermayer]

On Wed, May 21, 2008 at 09:26:03AM +0200, Vitor Sessak wrote:
> Hi
> 
> Michael Niedermayer wrote:
> > On Sun, May 11, 2008 at 05:45:29PM +0200, Vitor Sessak wrote:
> >> Michael Niedermayer wrote:
> >>> On Sat, May 10, 2008 at 04:50:03PM +0200, Vitor Sessak wrote:
> >>>> Hi,
> >>>>
> >>>> libavcodec/ra144.c really needs some cleanup. I'll start with the following:
> >>>>
> >>>> ra144_indent.diff: Reindent the whole file. Since there was no
> >>>> substantial change in this file since it inclusion in 2003, I don't
> >>>> think there is any problem in making its indentation inline with the
> >>>> rest of FFmpeg.
> >>>>
> >>>> ra144_unpack_rewrite.diff: Rewrite completely unpack_input()
> >>>>
> >>>> ra144_simp{1,2}.diff: minor simplifications
> >>> all ok if you have tested your code
> >> Next round:
> >>
> >> ra144_simp{3,4}.diff: minor simplifications (FFSWAP, unused stuff removal)
> >
> > ok
> >
> >
> >> ra144_sqrt.diff: remove ff_sqrt reimplementation and its corresponding
> >> big table (output is not anymore binary-identical but this function is
> >> more accurate, not less). Nice thing we have now a fast ff_sqrt :-)
> >
> > by how much does the output differ?
> 
> I found a way to keep it binary identical. ra144_sqrt2.diff.
> 
> Also ra144_decode_frame_loop.diff simplifies ra144_decode_frame()
> unrolling a senseless loop (thanks mkhodor for the suggestion).

all ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080521/45f0f1c9/attachment.pgp>