[FFmpeg-devel] [PATCH] remove unnecessary header files

Diego Biurrun diego
Thu May 29 15:38:39 CEST 2008


On Wed, May 28, 2008 at 07:49:30PM -0700, Erik Hovland wrote:
> This patch removes any header files that unnecessary to the files that
> include them.

Hmmmm

> --- a/ffmpeg.c
> +++ b/ffmpeg.c
> @@ -55,7 +55,6 @@
>  
> -#include "version.h"

Correct.

> --- a/ffplay.c
> +++ b/ffplay.c
> @@ -27,7 +27,6 @@
>  
> -#include "version.h"

Correct.

> --- a/ffserver.c
> +++ b/ffserver.c
> @@ -50,8 +50,6 @@
>  
> -#include "version.h"

Correct.

> -#include "ffserver.h"

Wrong.

> --- a/libavformat/siff.c
> +++ b/libavformat/siff.c
> @@ -20,7 +20,6 @@
>  
>  #include "avformat.h"
> -#include "riff.h"

Correct.

> --- a/libavformat/smacker.c
> +++ b/libavformat/smacker.c
> @@ -25,7 +25,6 @@
>  #include "avformat.h"
> -#include "riff.h"

Correct.

> --- a/libavformat/sol.c
> +++ b/libavformat/sol.c
> @@ -26,7 +26,6 @@
>  #include "raw.h"
> -#include "riff.h"

Correct.

> --- a/libavutil/tree.c
> +++ b/libavutil/tree.c
> @@ -19,7 +19,6 @@
>  
>  #include "common.h"
> -#include "log.h"

Wrong.

> --- a/vhook/watermark.c
> +++ b/vhook/watermark.c
> @@ -62,7 +62,6 @@
>  #include "libswscale/swscale.h"
> -#include "cmdutils.h"

Correct.

I haven't reviewed this completely, but I do not trust the rest of the
changes much.  I applied the correct changes that I noted above.

Diego




More information about the ffmpeg-devel mailing list