[FFmpeg-devel] [PATCH] Make long_names definition conditional depending on CONFIG_SMALL
Reimar Döffinger
Reimar.Doeffinger
Thu May 29 16:56:54 CEST 2008
On Thu, May 29, 2008 at 04:50:54PM +0200, Stefano Sabatini wrote:
> - const char *long_name; ///< descriptive name for the codec, meant to be more human readable than \p name
> + /**
> + * descriptive name for the codec, meant to be more human readable than \p name
> + * You \e should use the CODEC_REGISTER_LONG_NAME() macro to define it.
> + */
> + const char *long_name;
> const int *supported_samplerates; ///< array of supported audio samplerates, or NULL if unknown, array is terminated by 0
> } AVCodec;
>
> +#ifdef CONFIG_SMALL
> +#define REGISTER_CODEC_LONG_NAME(long_name_) \
> + .long_name = NULL
> +#else
> +#define REGISTER_CODEC_LONG_NAME(long_name_) \
> + .long_name = long_name_
> +#endif
Macro name does not match above description. Also I think the "REGISTER"
in the name does not make sense, it does not register anything.
I would find e.g. FF_CODEC_LONG_NAME better.
Greetings,
Reimar D?ffinger
More information about the ffmpeg-devel
mailing list