[FFmpeg-devel] [PATCH] remove unnecessary header files

[Erik Hovland]

On Thu, May 29, 2008 at 05:13:11PM +0200, Diego Biurrun wrote:
> On Thu, May 29, 2008 at 07:50:18AM -0700, Erik Hovland wrote:
> > On Thu, May 29, 2008 at 03:38:39PM +0200, Diego Biurrun wrote:
> > > > -#include "ffserver.h"
> > > 
> > > Wrong.
> > > 
> > > > --- a/libavutil/tree.c
> > > > +++ b/libavutil/tree.c
> > > > @@ -19,7 +19,6 @@
> > > >  
> > > >  #include "common.h"
> > > > -#include "log.h"
> > > 
> > > Wrong.
> > > 
> > > I haven't reviewed this completely, but I do not trust the rest of the
> > > changes much.  I applied the correct changes that I noted above.
> > 
> > Oh ye of little faith :)
> 
> Ummm, just look at tree.c, it uses av_log all over the place, which is
> declared in log.h ...

Then it likely gets log.h from another header before it. Because it
doesn't actually need that include.

> After looking again, it seems I was wrong about ffserver.c/ffserver.h.
> I will apply that change as well.

Thanks for giving it a second look.

> > But no sweat. I don't think they are necessary because the files that
> > include them do not use any code within them. But if you think they are
> > necessary, who am I to judge.
> 
> Well, I found those two errors above after a quick search, those other
> files would take more time to check.  Thus I'm not feeling confident
> enough to apply your patch right now.

I am not asking for the patch to be committed straight out. I recognize
that it may take some real thought to gain enough confidence to commit
all of the patch.

E

-- 
Erik Hovland
mail: erik at hovland.org
web: http://hovland.org/
PGP/GPG public key available on request