[FFmpeg-devel] [PATCH] Warn about PAFF & Spatial

[Michael Niedermayer]

On Thu, May 29, 2008 at 03:08:37PM -0400, Jeff Downs wrote:
> On Thu, 29 May 2008, Baptiste Coudurier wrote:
> 
> > Hi,
> > 
> > Carl Eugen Hoyos wrote:
> > > Hi!
> > > 
> > > Attached patch, which Michael proposed on -cvslog, helps understanding
> > > issue 460, and probably many others.
> > > 
> > > Carl Eugen
> > > 
> > > 
> > > ------------------------------------------------------------------------
> > > 
> > > Index: libavcodec/h264.c
> > > ===================================================================
> > > --- libavcodec/h264.c	(revision 13427)
> > > +++ libavcodec/h264.c	(working copy)
> > > @@ -4112,6 +4112,8 @@
> > >      if(h->slice_type == FF_P_TYPE || h->slice_type == FF_SP_TYPE || h->slice_type == FF_B_TYPE){
> > >          if(h->slice_type == FF_B_TYPE){
> > >              h->direct_spatial_mv_pred= get_bits1(&s->gb);
> > > +            if(FIELD_PICTURE && h->direct_spatial_mv_pred)
> > > +                av_log(h->s.avctx, AV_LOG_ERROR, "PAFF + spatial direct mode is not implemented\n");
> > >          }
> > >          num_ref_idx_active_override_flag= get_bits1(&s->gb);
> > >  
> > 
> > Anyone against this ? It is useful IMHO.
> 
> The warning for interlaced + spatial direct was (accidentally I think) 
> removed in r11806 when MBAFF + spatial direct was implemented.
> So I am for restoring it as per the patch.

i just was waiting for loren to say something as he removed it ...
but as he didnt reply, patch ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080529/09af46e5/attachment.pgp>