[FFmpeg-devel] bit func helpers
Baptiste Coudurier
baptiste.coudurier
Fri May 30 19:47:07 CEST 2008
Hi Michael,
Michael Niedermayer wrote:
> On Fri, May 30, 2008 at 02:00:22PM +0200, Andreas ?man wrote:
>> Hi
>>
>> I suggest we move these tiny helpers for dv.c to bitstream.h
>
> Code which is used just by dv stays in dv.
>
> If i disable dv, i dont want these compiled ...
> Besides the API is complex enough no need to add to it functions only used
> by a single codec.
>
> [...]
>
>> -static inline int get_bits_size(GetBitContext *s)
>> -{
>> - return s->size_in_bits;
>> -}
>
> I really think dv should use s->size_in_bits instead of this senseless
> wraper function but iam not dv maintainer, just my 2 cents ...
>
Patch attached, Roman ok to apply ?
--
Baptiste COUDURIER GnuPG Key Id: 0x5C1ABAAA
Smartjog USA Inc. http://www.smartjog.com
Key fingerprint 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dv_size_in_bits.patch
Type: text/x-diff
Size: 793 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080530/cea864b1/attachment.patch>
More information about the ffmpeg-devel
mailing list