[FFmpeg-devel] [PATCH] Support for Dirac in ogg

[David Conrad]

On Nov 5, 2008, at 8:10 AM, Diego Biurrun wrote:

> On Wed, Nov 05, 2008 at 03:32:22AM -0500, David Conrad wrote:
>>
>> Attached adds demuxing support for dirac in ogg files. It uses a  
>> couple
>> functions for the soc dirac decoder to parse the header, updated to  
>> the
>> latest specification.
>
> This begs for the question: What about the rest of the Dirac decoder?

It crashes on modern streams. I'm (slowly) going through the current  
spec and updating the code, however.

On that note, does anyone mind me committing to the soc dirac  
repository?

>> +    /* Override clean area.  */
>
> Are these double spaces at the end of comments on purpose?  Not that  
> it
> matters..

Mostly I simply didn't make cosmetic changes even if I didn't like the  
style. I do prefer what your nits are leading to however, so I'll  
change the comments throughout the decoder.