[FFmpeg-devel] [PATCH] Function to parse Dirac sequence header

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Fri, Nov 07, 2008 at 04:24:01AM -0500, David Conrad wrote:
>> On Nov 6, 2008, at 5:15 AM, Diego Biurrun wrote:
>>
>>> On Wed, Nov 05, 2008 at 11:22:01PM -0500, David Conrad wrote:
>>>>
>>>> This will be useful for both the dirac parser and ogg demuxer (and
>>>> future native dirac decoder of course.)
>>>> Adapted from the soc repository.
>>>>
>>>> --- /dev/null
>>>> +++ b/libavcodec/dirac.c
>>>> @@ -0,0 +1,259 @@
>>>> +    /* framerate */
>>>> +    if (get_bits1(gb)) {
>>>> +        source->frame_rate_index = svq3_get_ue_golomb(gb);
>>>
>>> This function is used in svq3.c, rv30.c, rv40.c and now dirac.c.
>>> Clearly, the svq3_ prefix is misleading and it should be renamed.
>>>
>>> Does anybody have a suggestion for a better name?
>>
>> Going by what Kostya said, "get_ue_elias()"?
>
> and what is this supposed to stand for?
> ue_golomb was "unsigned exponential golomb"
>
> iue_golomb for interleaved unsigned exponential golomb seems to make more
> sense or iu_elias_gamma if we follow kostyas suggestion but thats longer
> droping i, u or gamma makes it ambigous ...

Whatever the most technically/historically correct name, I suggest we
call it whatever everybody else does in specs etc.  That should make
for the least confusion.

-- 
M?ns Rullg?rd
mans at mansr.com