[FFmpeg-devel] Mutlichannel API for aac.c

[Michael Niedermayer]

On Sun, Nov 02, 2008 at 10:25:36PM +0100, Andreas ?man wrote:
> Hi,
>
> aac1.patch is basically some refactoring.

iam mildly against this, at least without renaming the involved functions
to repesent the new merged behavior and fully documenting it but with these
its likely no longer a win in terms of amount of code.


>
> aac2.patch does the stuff but depends on mpeg4audio.patch.

iam against this patch, not only does it replace apparently
unrelated code by a more complex and more messy implementation, it also
does not seem to implement channel layouts correctly. Rather it just hardcodes
them for defaults while ignoring non defaults.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081108/65d0de69/attachment.pgp>