[FFmpeg-devel] [PATCH] QCELP decoder

[Michael Niedermayer]

On Sun, Nov 09, 2008 at 02:03:39PM -0300, Reynaldo H. Verdejo Pinochet wrote:
> Hello
> 
> Michael Niedermayer wrote:
> > 
> > also this belongs in a file seperate from the qcelp decoder so it can be
> > shared with other decoders.
> 
> Now I understand why Kenan splitted it. do you have a
> preferred name for it? The proposed qcelp_lsp.c seems
> odd.

i agree that qcelp should not be in the name i do not have a good name
though :(


> 
> >> +    case SILENCE:
> >> +        av_log_missing_feature(avctx, "Blank frame", 1);
> >> +    default:
> >> +        q->framerate = I_F_Q;
> > 
> > is it intended that SILENCE sets IFQ ?
> 
> Not in my code, this is the kind of changes I'd like
> to see out of the 'merging' attempt and back as
> patches against the SoC code, I don't have your gifted
> sight, I get lost. Merging the soc code with cosmetic
> fixes into HEAD and latter working on these functional
> changes would be OK too. Is that something you'd be
> willing to accept? I'm OK with either way, I just
> don't want to handle both tasks in the same patchset.

code wont be commited to HEAD until its ok both functionally and cosmetically
about following kenans changes, well, we could just give him write access
to soc-svn if you agree, or if he is using git or something like that he
maybe could provide some history between soc and the current code.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081109/12215912/attachment.pgp>