[FFmpeg-devel] [PATCH] fixes in mpeg audio parsing

Yoav Steinberg yoav
Wed Nov 12 18:02:55 CET 2008


Hi,
Attached are patches witch make some improvements for mp3 parsing.
skip_vbrtag_and_id3v1.patch:
- When file contains ID3v1 tag at the end don't attempt to read it as 
part of a packet. In some cases there are mp3 files where the ID3v1 tag 
was stuck forcefully at the end of the file inside the last frame 
boundary. In those cases the patch eliminates attempts to parse/decode 
the ID3 tag.
- If we find a VBR tag at the beginning of the file don't attempt to 
parse it as a valid frame.
parse_all_frames.patch:
- Buffer packets when we loose sync and start counting "valid" frames 
until parser returns a valid frame. Then return buffered frames once 
we're back in sync. This prevents the parser from discarding valid 
frames in many cases.

The goal of these patches was to improve the parsing of mp3 files so we 
only parse/decode the actual (and all of) the audio data.
I also notice there's no CRC checks performed on mpeg audio frames with 
CRC info - this is a future to do:)
	Yoav.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: skip_vbrtag_and_id3v1.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081112/a6a91a4d/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: parse_all_frames.patch
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081112/a6a91a4d/attachment.txt>



More information about the ffmpeg-devel mailing list