[FFmpeg-devel] [PATCH] 'j_rev_dct_ARM' bugfix

Diego Biurrun diego
Thu Nov 13 00:28:24 CET 2008


On Wed, Nov 12, 2008 at 08:29:14PM +0000, M?ns Rullg?rd wrote:
> Siarhei Siamashka <siarhei.siamashka at gmail.com> writes:
> 
> > This is a bugfix for ARMv4 assembly implementation of 'j_rev_dct' function.
> >
> > The problem was in the incorrect partially empty row detection. Even
> > if the first two coefficients in the row were nonzero, it handled
> > this just like the case with only the first nonzero coefficient.
> >
> > Now this function produces exactly the same output as the stripped
> > down reference C version of 'j_rev_dct' (with the nested checks like
> > 'if (d6) { if (d2) { ...' always evaluated as true, avoiding
> > shortcut branches).
> 
> Thanks, applied.

Note that Siarhei is a committer now.

Diego




More information about the ffmpeg-devel mailing list