[FFmpeg-devel] [patch] 6 channelrawaudioinputresultsininvalid PCM packet error
Michael Niedermayer
michaelni
Fri Nov 14 18:42:43 CET 2008
On Wed, Nov 12, 2008 at 04:30:12PM -0800, Phil Rutschman wrote:
> > your original logic generates packets that are not a multiple of 512
> or
> > 1024 thus not a multiple of disk sectors, this seems not ideal
>
> It generates these packets only in cases which currently fail entirely.
> While this may not be ideal (at least, if there is neither OS nor C
> library caching going on), it has the virtue of solving the problem at
> hand without changing current behavior.
>
> > in principle updating the regression test checksums would be fine, but
> > why does g726 change? this looks like there is something wrong in g726
> > which has to be found and fixed ...
>
> It is worth observing that the size of the mov and mkv files change, not
> just their checksum. When I extract the raw audio data from
> tests/data/a-pcm_s16be.mov and strip the header, the file matches the
> original asynth1.sw file except that it is not quite as long. Reducing
> RAW_PACKET_SIZE increases the size of the resulting mov file, and
> conversely increasing it results in a smaller mov.
>
> Something odd overall is clearly happening related to RAW_PACKET_SIZE,
> which may or may not be related to the g726 issue, but I don't currently
> have the time to investigate the specifics of either.
so the summary is we need some volunteer to fix
1. g726
2. mov/mkv loosing some samples depending on RAW_PACKET_SIZE
after that pcm can be fixed and regression checksums updated.
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081114/4b3cc151/attachment.pgp>
More information about the ffmpeg-devel
mailing list