[FFmpeg-devel] [PATCH] fix small memleak in rdt.c

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Fri, Nov 14, 2008 at 02:04:00PM -0800, Baptiste Coudurier wrote:
>> Michael Niedermayer wrote:
>>> On Fri, Nov 14, 2008 at 03:17:26PM -0500, Ronald S. Bultje wrote:
>>>> Hi,
>>>>
>>>> $subj.
>>>>
>>>> Sidenote: if url_open_buf() allocates, shouldn't url_close_buf() free
>>>> it? That doesn't appear to be the case right now, hence my confusion
>>>> when I originally implemented this... Maybe the API should be renamed
>>>> or something? Or a comment in the API docs?
>>> id say mark both as deprecated and put them under #if VERSION < X
>>> close is unused, open is just used by ffserver.c
>> Humm :/
>> Well is it possible then to rename init_put_byte, etc... to more decent
>> names ?
>> Like: av_alloc_byteio_context, av_init_byteio_context ?
> 
> isnt the existing av_alloc_put_byte() enough?

Its name is inappropriate and inconsistent with other lavf functions,
this structure is also used to read for example.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no