[FFmpeg-devel] [PATCH] QCELP decoder

Reynaldo H. Verdejo Pinochet reynaldo
Sat Nov 15 01:12:31 CET 2008


Hello Kenan

Kenan Gillet wrote:
> Hi,
> On Nov 13, 2008, at 7:15 PM, Reynaldo H. Verdejo Pinochet wrote:
>>> + * TIA/EIA/IS-733 2.4.3.2.6.2-2, 2.4.8.7.3
>>> + */
>>> +static int decode_lspf(QCELPContext *q,
>>> +                       float *lspf) {
>> Unneeded line break?
> 
> it is done for consistency purpose.

Where you asked to do this? I use it for lines that go beyond
80+ chars an in that case I usually try to choose a meaningful
breaking point, like you did there just that this wasn't a
'deserving' line. If you weren't asked to do this please revert,
is just meaningless line butchering.

Bests
--
Reynaldo H. Verdejo Pinochet




More information about the ffmpeg-devel mailing list