[FFmpeg-devel] [PATCH/RFC] change function prototype of parse_sdp_a_line

[Luca Abeni]

Hi Ronald,

Ronald S. Bultje wrote:
> Hi Luca,
> 
> On Mon, Nov 17, 2008 at 2:55 PM, Luca Abeni <lucabe72 at email.it> wrote:
>> But I give up, and I'll leave this discussion to the rtsp maintainer.
> 
> No, no, that's not what I want, it's a RFC, I'd like your opinion on
> how you'd do it.

Well, by "I give up" I mean that at this point I do not object to your
patch anymore.

I believe that the problem is (once again :) due to the fact that the
original design of the RTSP client did not account for multiple qualities.
So, every media is associated to one and only one stream... Now, you are
changing this assumption. I think the best way to support multiple qualities
would be to redesign this part of the RTSP client, changing the RTSPStream
in a "Media descriptor" (or adding this "Media descriptor" to RTSPStream)
or similar, that can contain a link to all the streams provided for a media.
And the parse_sdp_a_line() method can receive a pointer to the
"Media descriptor" as a parameter.

But this would be a significant change, requiring a some amount of work
and some discussion about the design... So, I think the maintainer
opinion is more relevant than my one (this is what I meant by "I'll leave
this discussion to the maintainer).


				Luca