[FFmpeg-devel] [PATCH] RDT/Realmedia patches #2

[Michael Niedermayer]

On Tue, Nov 18, 2008 at 08:29:09PM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Nov 17, 2008 at 6:32 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Mon, Nov 17, 2008 at 6:14 PM, Benoit Fouet <benoit.fouet at free.fr> wrote:
> >> Ronald S. Bultje a ?crit :
> >>> +     *   this particular RTPSStream and its RTP parsing context (this one)
> >>
> >> why are you adding '(this one)' ?
> >
> > The RTP parsing context is the one in which these structures live,
> > i.e. it is RTPDemuxContext.
> >
> > Will fix the <, doxy is kind of confusing, thanks...
> 
> I replaced the "(this one)" with something better, and removed the <.
> See attached.
> 
> Ronald

> Index: ffmpeg-svn/libavformat/rdt.c
> ===================================================================
> --- ffmpeg-svn.orig/libavformat/rdt.c	2008-11-18 20:24:07.000000000 -0500
> +++ ffmpeg-svn/libavformat/rdt.c	2008-11-18 20:26:47.000000000 -0500
> @@ -36,7 +36,12 @@
>  #include <libavcodec/bitstream.h>
>  
>  struct RDTDemuxContext {
> -    AVFormatContext *ic;
> +    AVFormatContext *ic; /**< the containing (RTSP) demux context */
> +    /** stream context of the first stream of the set of streams that
> +     *  this particular RTPSStream and its contained RDTDemuxContext
> +     *  are describing. In case of multiple streams per set, the rest
> +     *  of the streams are directly following in the streams array
> +     *  of the 'ic' variable (e.g. me->ic->streams[me->st->index + 1]) */
>      AVStream *st;

I think this design is a mess ...
At least st should be renamed to something like first_st_of_set


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/c940ee12/attachment.pgp>