[FFmpeg-devel] [PATCH] Fix shared build on OS X

[Michael Niedermayer]

On Wed, Nov 19, 2008 at 01:41:43PM -0500, David Conrad wrote:
> Hi,
>
> Currently compilation on OS X intel with --enable-shared fails with (using 
> apple gcc 4.0.1)
>
> ffmpeg/libavcodec/i386/cavsdsp_mmx.c: In function 
> ?ff_put_cavs_qpel8_mc01_3dnow?:
> ffmpeg/libavcodec/i386/cavsdsp_mmx.c:448: error: can't find a register in 
> class ?GENERAL_REGS? while reloading ?asm?
>
> This seems to be because gcc decides to use edi for the ADD constant 
> instead of memory and borks when the constraints specify its use for 
> dstStride.
>
> Attached patch is the minimal needed to fix the build for me, but I think 
> that all these named registers should probably be replaced with the general 
> "r". Comments?

Have you confirmed that
1. the genrated code is not miscompiled after the patch
2. svn blame/log why its "D" and not "r" ? i faintly remember this was
   like that because of some gcc issue
3. checked that it still works on other gccs? especially 2.95/3.4/4

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Freedom in capitalist society always remains about the same as it was in
ancient Greek republics: Freedom for slave owners. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081119/98ab71bf/attachment.pgp>