[FFmpeg-devel] [PATCH] H.264 data tables cleanup

[Michael Niedermayer]

On Thu, Nov 20, 2008 at 09:46:29AM +0100, Diego Biurrun wrote:
> On Thu, Nov 20, 2008 at 09:08:17AM +0100, Michael Niedermayer wrote:
> > On Thu, Nov 20, 2008 at 12:49:03AM +0100, Diego Biurrun wrote:
> > > So I've (re)started working on splitting off svq3.c from h264.c.
> > > 
> > > Here are some simple first steps:
> > > 
> > > - Remove unused tables from h264data.h.
> > 
> > these tables are unused because we dont have an encoder ...
> > putting them under appropriate ifdef or in a seperate encoder
> > specific (not compiled) header seems better than removing them
> > even if there are no plans for an encoder ...
> 
> I don't think it's a good idea to keep cruft around forever.  Also, we
> are just talking about a handful lines of code.  Nobody will waste a
> huge amount of time reimplementing them.

its not cruft, it very well could be usefull for a simple h264 bitstream
generator for regression tests. I mean something that maybe just generates
a random bitstream with random coefficients and motion vectors.


> 
> > > - Move a table that is only used there to svq3.c.
> > 
> > there is
> > static const uint8_t slice_type_map[5]= {FF_P_TYPE, FF_B_TYPE, FF_I_TYPE, FF_SP_TYPE, FF_SI_TYPE};
> > in h264.c
> 
> This is indeed a duplicate of golomb_to_pict_type.  So what do you want
> done?

id make the code in h264.c use the table ...
less code duplication ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20081120/1cfb2a13/attachment.pgp>