[FFmpeg-devel] [PATCH] QCELP decoder

[Kenan Gillet]

On Nov 20, 2008, at 5:13 PM, Michael Niedermayer wrote:

> On Thu, Nov 20, 2008 at 04:50:46PM -0800, Kenan Gillet wrote:
>>
>> On Nov 20, 2008, at 4:03 PM, Reynaldo H. Verdejo Pinochet wrote:
> [...]
>> Concerning the renaming issue, the unpacking used to be done
>> 1bit at a time in the SoC code, and qcelp_bits_per_rate was
>> used more like the size of the unpacking tables.
>> But during the review, Michael remarked that the unpacking
>> could be done by block of bits instead, which would lead to smaller
>> unpacking table and even maybe some faster code.
>
> besides smaller and faster, i really think the new tables are more
> readable due to containing actual names of fields in the source  
> instead
> of just litteral numbers

I agree, I forgot it is more readable :)