[FFmpeg-devel] "make check" fails on MacOS X

[David Geldreich]

Hello Dominik,

>
> Could you do a SVN bisection to backtrack to the last revision in  
> which
> make check completed successfully and identify the commit that broke  
> it
> for you?

This took me some times (>80 minutes, 20 build/test...), but I found  
the problematic commit.

15260 is passing the codectest without problem
15261 is failing

the change is :

svn diff -r15260:15261
Index: libavcodec/mdct.c
===================================================================
--- libavcodec/mdct.c	(revision 15260)
+++ libavcodec/mdct.c	(revision 15261)
@@ -59,10 +59,9 @@

  // Generate a sine window.
  void ff_sine_window_init(float *window, int n) {
-    float alpha = M_PI / (2.0 * n);
      int i;
      for(i = 0; i < n; i++)
-        window[i] = sin((i + 0.5) * alpha);
+        window[i] = sinf((i + 0.5) * (M_PI / (2.0 * n)));
  }

  /**

In the first case the computation is made using a precomputation with  
float and in the second case double are used.

If I replace "float alpha" with "double alpha" in 15260, I got the  
same result (same checksum for a-wmav1.asf) as in 15261.

So I propose to upgrade the ref files with this new window "side- 
effect".

Thanks in advance.

PS: this patch works with 15261 and 15899 on Intel Mac/gcc 4.0