[FFmpeg-devel] [PATCH] convert fdct_mmx.c to plain asm

[Baptiste Coudurier]

Michael Niedermayer wrote:
> On Thu, Nov 13, 2008 at 10:39:37AM -0800, Baptiste Coudurier wrote:
>> Hi Michael,
>>
>> Michael Niedermayer wrote:
>>> On Wed, Nov 12, 2008 at 06:54:23PM -0800, Baptiste Coudurier wrote:
>>>> Hi
>>>>
>>>> $subject, I hope I did not mess up.
>>> ok, if its output didnt change
>> Yeah, it is obvious. No other comment ?
> 
> I have many but they dont belong in this patch :)
> like not using "r" but MANGLE() to prevent slow GOT indirection,
> and to turn the asm parts into just parts of a single asm() instead of
> 3 asm()
> 
> 
>> Like a better way to use the macro, I find it a bit ugly.
> 
> #define SHIFT_FRW_COL_STR "3"
> should work to avoid S()

Btw, I noticed some funcs are using %n, and "i" constraint, wouldn't it
be better ?

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no